Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkbox, radio-button): restore support for labelHelp and fieldHelp #6964

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(checkbox, radio-button): restore support for labelHelp and fieldHelp #6964

merged 2 commits into from
Sep 18, 2024

Conversation

Parsium
Copy link
Contributor

@Parsium Parsium commented Sep 18, 2024 •
edited
Loading

Proposed behaviour

Current behaviour

Support for labelHelp and fieldHelp props was removed from Checkbox and RadioButton when using the feature flag validationRedesignOptIn

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@Parsium Parsium self-assigned this Sep 18, 2024
@Parsium Parsium changed the title feat(checkbox, radio-button): restore support for labelHelp and fieldHelp fix(checkbox, radio-button): restore support for labelHelp and fieldHelp Sep 18, 2024
@Parsium Parsium marked this pull request as ready for review September 18, 2024 10:20
@Parsium Parsium requested review from a team as code owners September 18, 2024 10:20
@Parsium Parsium merged commit 4f9ccaa into master Sep 18, 2024
25 checks passed
@Parsium Parsium deleted the restore-field-help branch September 18, 2024 10:39
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 142.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edleeks87 edleeks87 edleeks87 approved these changes

@DipperTheDan DipperTheDan DipperTheDan approved these changes

Assignees

@Parsium Parsium

Labels
No QA Required No UX QA Required Passed Review released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Parsium @carbonci @edleeks87 @DipperTheDan