Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation-bar): move context provider to not wrap parent #6960

Merged
merged 2 commits into from
Sep 20, 2024

Commits on Sep 17, 2024

  1. fix(navigation-bar): move context provider to not wrap parent

    The FixedNavigationBarContextProvider, which uses a ResizeObserver to respond to size changes on the
    navbar element, currently wraps that same element. This can result in unexpected ResizeObserver
    errors on initial render, when a media query is being used to determine layout. The context provider
    only needs to wrap the navbar's children, and by moving it down the React tree to only wrap the
    children and not the parent, the error goes away.
    robinzigmond committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a265b1c View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    66064bc View commit details
    Browse the repository at this point in the history