Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(radio-button-mapper): convert enzyme tests to RTL #6959

Merged
merged 2 commits into from
Sep 17, 2024
Merged

refactor(radio-button-mapper): convert enzyme tests to RTL #6959

merged 2 commits into from
Sep 17, 2024

Conversation

nuria1110
Copy link
Contributor

Proposed behaviour

Convert tests to RTL

Current behaviour

Tests are in enzyme

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@nuria1110 nuria1110 self-assigned this Sep 16, 2024
@nuria1110 nuria1110 marked this pull request as ready for review September 17, 2024 15:20
@nuria1110 nuria1110 requested a review from a team as a code owner September 17, 2024 15:20
@nuria1110 nuria1110 merged commit d1c012e into master Sep 17, 2024
24 checks passed
@nuria1110 nuria1110 deleted the FE-6785-radio-button-mapper-rtl branch September 17, 2024 15:41
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 142.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parsium Parsium Parsium approved these changes

@tomdavies73 tomdavies73 Awaiting requested review from tomdavies73

Assignees

@nuria1110 nuria1110

Labels
No QA Required No UX QA Required Passed Review released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nuria1110 @carbonci @Parsium @tomdavies73