refactor(checkable-input): convert enzyme tests to RTL #6953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsium
reviewed
Sep 16, 2024
nuria1110
force-pushed
the
FE-6634-checkable-rtl
branch
from
c7f52d9
to
d082e14
Compare
DipperTheDan
approved these changes
Sep 17, 2024
Parsium
reviewed
Sep 17, 2024
| @@ -114,6 +114,35 @@ test("should render tooltip with provided labelHelp and helpAriaLabel", async () | |||
| expect(helpTooltip).toHaveAccessibleDescription("labelHelp"); | |||
| }); | |||
|
|
|||
| test("should render input with validation tooltip as its accessible description when the input is focused", async () => { | |||
There was a problem hiding this comment.
praise: good idea to include this so the intended outcome of handling the element ids is covered 👍🏼
Parsium
approved these changes
Sep 17, 2024
|
🎉 This PR is included in version 142.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Convert tests to RTL.
Current behaviour
Tests are in enzyme.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions