-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(popover): rewrite jest tests to use RTL #6946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsium
force-pushed
the
FE-6789/popover-rtl
branch
from
September 11, 2024 16:13
7db7668
to
e0eb2c2
Compare
Parsium
commented
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: well done for completely rewriting the existing test suite - it's now doing a much better job of testing the component's behaviour rather than implementation details 👏
src/__internal__/conditional-wrapper/conditional-wrapper.component.tsx
Outdated
Show resolved
Hide resolved
src/__internal__/conditional-wrapper/conditional-wrapper.component.tsx
Outdated
Show resolved
Hide resolved
Parsium
force-pushed
the
FE-6789/popover-rtl
branch
from
September 13, 2024 12:42
e0eb2c2
to
f85fc39
Compare
Parsium
changed the title
refactor(popover): rewrite enzyme tests in RTL
refactor(popover): rewrite jest tests to use RTL
Sep 13, 2024
Parsium
force-pushed
the
FE-6789/popover-rtl
branch
3 times, most recently
from
September 13, 2024 13:21
9fb7a67
to
fcbbaf6
Compare
robinzigmond
previously approved these changes
Sep 16, 2024
Parsium
force-pushed
the
FE-6789/popover-rtl
branch
from
September 16, 2024 14:37
fcbbaf6
to
46cd764
Compare
DipperTheDan
approved these changes
Sep 16, 2024
robinzigmond
approved these changes
Sep 16, 2024
Parsium
force-pushed
the
FE-6789/popover-rtl
branch
from
September 16, 2024 15:14
46cd764
to
d00d976
Compare
🎉 This PR is included in version 142.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Popover
using React Testing Library (RTL)Current behaviour
Popover
are currently use EnzymeChecklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions