Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fonts): updated font weights for ds base token alignment #6944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harpalsingh
Copy link
Member

@harpalsingh harpalsingh commented Sep 10, 2024

Proposed behaviour

Updating the fonts so that we see the following range:

  • 700 - the new thickest weight relative number
  • 500 - the new "bold" weight
  • 400 - this is the same as currently implemented

Current behaviour

The current weights are:

  • 900
  • 700
  • 400

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

A note for QA - you should see NO DIFFERENCE with components. Though the title segments in Storybook might be thicker, not sure how we manage that, but no component should look different from what they do today, that is the QA part.

Additional context

Testing instructions

@harpalsingh harpalsingh requested review from a team as code owners September 10, 2024 14:41
@harpalsingh harpalsingh self-assigned this Sep 10, 2024
@harpalsingh harpalsingh force-pushed the font_weight_updates_sep2024 branch 6 times, most recently from 7240b27 to 91da40d Compare September 11, 2024 13:22
Parsium
Parsium previously approved these changes Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants