refactor(character-count, field-help): convert enzyme tests to RTL #6941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdavies73
changed the title
robinzigmond
approved these changes
Sep 10, 2024
| expect(visuallyHiddenHint).toHaveTextContent("5 characters too many"); | ||
| }); | ||
|
|
||
| test("visually hidden character counter is visually hidden", () => { |
There was a problem hiding this comment.
suggestion (non-blocking): both this test and the other one for visually hidden styles could perhaps be removed, as Chromatic should surely catch it if we accidentally make it visible?
mihai-albu-sage
approved these changes
Sep 11, 2024
|
🎉 This PR is included in version 142.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
CharacterCount: Converts current enzyme tests to RTL.FieldHelp: Removes all enzyme tests, due to all tests being styling tests and there being sufficient test alternatives (Chromatic & Playwright)Current behaviour
Currently, all tests are written in enzyme for both
CharacterCount&FieldHelp.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions