refactor(search): convert tests to react testing library #6940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsium
previously approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Great job on this @robinzigmond! 👏🏼 Just one small suggestion below, but overall, this looks solid and I’m happy to approve.
| @@ -245,7 +245,7 @@ export const Search = React.forwardRef<SearchHandle, SearchProps>( | |||
| variant={variant} | |||
| mb={0} | |||
| {...filterStyledSystemMarginProps(rest)} | |||
| {...tagComponent("search", rest)} | |||
| {...tagComponent("search", { "data-role": "search", ...rest })} | |||
There was a problem hiding this comment.
suggestion(non-blocking): what do you think about defining the props directly here? It might help with readability.
Suggested change
| {...tagComponent("search", { "data-role": "search", ...rest })} | |
| data-component="search" | |
| data-role="search" |
DipperTheDan
previously approved these changes
Sep 12, 2024
robinzigmond
dismissed stale reviews from DipperTheDan and Parsium
via
7ec2e34
Parsium
approved these changes
Sep 12, 2024
DipperTheDan
approved these changes
Sep 12, 2024
robinzigmond
force-pushed
the
FE-6628-search-rtl
branch
from
be29e6a
to
e862a08
Compare
|
🎉 This PR is included in version 142.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Search unit tests should use React Testing Library
Current behaviour
Tests use Enzyme
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions