Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(duelling-picklist): fix storybook docs page not displaying in production #6938

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

nuria1110
Copy link
Contributor

@nuria1110 nuria1110 commented Sep 6, 2024

Proposed behaviour

Remove test story import and add it to public stories.

Current behaviour

Storybook docs page for DuellingPicklist is not displaying in production.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

  • Adds Chromatic snapshots for "Default" and "InDialog" stories.
  • To test when merged to make sure this has been fixed as issue is only present in prod.

Parsium
Parsium previously approved these changes Sep 9, 2024
Copy link
Contributor

@Parsium Parsium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @nuria1110! The docs page is visible again when the test stories are ignored 👍🏼

mihai-albu-sage
mihai-albu-sage previously approved these changes Sep 9, 2024
@nuria1110 nuria1110 merged commit 600ac5f into master Sep 20, 2024
24 checks passed
@nuria1110 nuria1110 deleted the FE-6776 branch September 20, 2024 08:45
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 142.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants