refactor(pages): convert unit tests to use react-testing-library #6935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineteen88
reviewed
Sep 9, 2024
src/components/pages/pages.test.tsx
Outdated
| @@ -0,0 +1,178 @@ | |||
| /* eslint-disable react/prop-types */ | |||
There was a problem hiding this comment.
suggestion: remove the eslint disable here
I don't believe it's required for this file and therefore can just be removed
Parsium
reviewed
Sep 12, 2024
src/components/pages/pages.test.tsx
Outdated
| expect(screen.getByRole("heading")).toHaveTextContent("Page 2"); | ||
| }); | ||
|
|
||
| test("navigating to the next page should work as expected", async () => { |
There was a problem hiding this comment.
suggestion(non-blocking): for this test and the succeeding one, what do you think about this so the expected behaviour is clearer?
Suggested change
| test("navigating to the next page should work as expected", async () => { | |
| test("navigating to the next page renders its content", async () => { |
Parsium
approved these changes
Sep 12, 2024
nineteen88
approved these changes
Sep 13, 2024
robinzigmond
force-pushed
the
FE-6617-pages-rtl
branch
from
d155705
to
cc67e7d
Compare
|
🎉 This PR is included in version 142.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Pages component should have unit tests using React Testing Library
Current behaviour
unit tests use Enzyme
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions