Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): tabbing in FireFox - focus incorrect #6933

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix(form): tabbing in FireFox - focus incorrect #6933

merged 2 commits into from
Sep 19, 2024

Conversation

mihai-albu-sage
Copy link
Contributor

Proposed behaviour

When tabbing through a form in FireFox browser, the form as a whole should not be focusable and the focus should jump to the first focusable element within the form

after.mp4

Current behaviour

When tabbing through a form in FireFox browser, the form as a whole is focusable and highlighted in blue.

before.mp4

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@mihai-albu-sage mihai-albu-sage self-assigned this Sep 5, 2024
@mihai-albu-sage mihai-albu-sage requested a review from a team as a code owner September 5, 2024 08:56
@Parsium Parsium self-requested a review September 5, 2024 09:48
Parsium
Parsium previously approved these changes Sep 5, 2024
View reviewed changes
edleeks87
edleeks87 previously approved these changes Sep 6, 2024
View reviewed changes
@mihai-albu-sage
fix(form, dialog): tabbing in FireFox - focus incorrect
43ff681 
tabIndex with a value of -1 has been added to prevent the focus in FireFox
@mihai-albu-sage mihai-albu-sage merged commit f55c877 into master Sep 19, 2024
24 checks passed
@mihai-albu-sage mihai-albu-sage deleted the FE-6762 branch September 19, 2024 12:28
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 142.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulrobinson88 paulrobinson88 paulrobinson88 approved these changes

@edleeks87 edleeks87 edleeks87 approved these changes

@Parsium Parsium Parsium approved these changes

Assignees

@mihai-albu-sage mihai-albu-sage

Labels
Passed QA Passed Review Pending UX QA released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mihai-albu-sage @carbonci @Parsium @edleeks87 @paulrobinson88