Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): tab headers jump in width when navigating through them #6925

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

mihai-albu-sage
Copy link
Contributor

@mihai-albu-sage mihai-albu-sage commented Sep 2, 2024

fixes: #6554

Proposed behaviour

The width for the StyledTab component has been changed from auto and it is computed based on the value received from headerWidth preventing any resizing to occur.

after.mp4

Current behaviour

When the Tabs component has align="left", position="left" and headerWidth is specified the width of the StyledTab component is set to auto allowing it to resize based on the inner content.

before.mp4

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Parsium
Parsium previously approved these changes Sep 4, 2024
nineteen88
nineteen88 previously approved these changes Sep 4, 2024
when using headerWidth the min width of the styled tab is updated

fixes: #6554
@Parsium Parsium marked this pull request as draft September 12, 2024 08:09
@harpalsingh harpalsingh marked this pull request as ready for review September 13, 2024 09:28
@mihai-albu-sage mihai-albu-sage merged commit 2d7521b into master Sep 19, 2024
24 checks passed
@mihai-albu-sage mihai-albu-sage deleted the FE-6346 branch September 19, 2024 12:48
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 142.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The property "headerWidth" in <Tabs /> should configure "tab list" only
7 participants