Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-editor): content overflows in small viewports #6750

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix(text-editor): content overflows in small viewports #6750

merged 2 commits into from
Jun 6, 2024

Conversation

nuria1110
Copy link
Contributor

fix #6707

Proposed behaviour

Text container maintains the same width as the component and does not overflow.
Screenshot 2024-05-23 at 13 43 02

Current behaviour

Text container overflows outside of the component in small viewports.
Screenshot 2024-05-23 at 13 42 14

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@nuria1110
fix(text-editor): content overflows in small viewports
c985d5d 
Fixes bug where the text container in `TextEditor` would overflow outside component width in
small viewports.

fix #6707
@nuria1110 nuria1110 self-assigned this May 23, 2024
edleeks87
edleeks87 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm happy with these changes, @harpalsingh can you confirm you're okay with us removing the fixed min-width as that was a requirement when I originally built the TextEditor and the Toolbar buttons will now overflow at very small resolutions etc. If you are we can raise a ticket for wrapping the buttons

@DipperTheDan DipperTheDan marked this pull request as ready for review May 28, 2024 14:00
@DipperTheDan DipperTheDan requested review from a team as code owners May 28, 2024 14:00
@nuria1110 nuria1110 merged commit 9a6170e into master Jun 6, 2024
21 checks passed
@nuria1110 nuria1110 deleted the FE-6572-text-editor branch June 6, 2024 13:26
@carbonci
Copy link
Collaborator

carbonci commented Jun 6, 2024

🎉 This PR is included in version 136.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edleeks87 edleeks87 edleeks87 approved these changes

@DipperTheDan DipperTheDan DipperTheDan approved these changes

@ZhuoyuJin ZhuoyuJin ZhuoyuJin approved these changes

Assignees

@nuria1110 nuria1110

Labels
Passed QA Passed Review Passed UX QA released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text Editor content overflows on small devices
6 participants
@nuria1110 @carbonci @edleeks87 @DipperTheDan @ZhuoyuJin @harpalsingh