Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jhalackova sle 17523 #1180

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Jhalackova sle 17523 #1180

wants to merge 3 commits into from

Conversation

lvicoun
Copy link
Contributor

@lvicoun lvicoun commented Apr 27, 2022

PR creator: Description

Applying changes for RPi 4 - updating settings in config.txt.

PR creator: Are there any relevant issues/feature requests?

  • jsc#SLE-17523

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE 15/openSUSE Leap 15.x
    • SLE 15 SP4/openSUSE Leap 15.4 (current main, no backport necessary)
    • SLE 15 SP3/openSUSE Leap 15.3
    • SLE 15 SP2/openSUSE Leap 15.2
    • SLE 15 SP1
    • SLE 15 GA
  • SLE 12
    • SLE 12 SP5
    • SLE 12 SP4
    • SLE 12 SP3

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

@lvicoun lvicoun requested a review from afaerber April 27, 2022 11:07
Copy link
Collaborator

@afaerber afaerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text needs to be reworked.

Nit: SLE15 SP3/SP4 checkboxes are broken, possibly due to trailing spaces? UPDATE: Yes, fixed.

SLE Micro 5.x based on SP3 and later will also be affected, if it ships this guide.

@@ -144,6 +144,38 @@
<literal>config.txt</literal> file when needed, without overwriting any
user settings.
</para>
<para>
To override the settings from <literal>config.txt</literal> on &rpi4;, proceed as
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not the purpose of this tool, it is about a separate EEPROM config.

Comment on lines +168 to +169
Use the <command>rpi-eeprom-update</command> tool to apply changes of the
<filename>extraconfig.txt</filename> file:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the tool is used to flash updated EEPROM firmware (plus a config for that firmware). For example, for early RPi4 models this may add support for booting from USB. Thus it should go into a new sect3 "EEPROM on Raspberry Pi 4" or so. It is not the same config as for the non-EEPROM components and should not overwrite any user-authored extraconfig.txt.

@@ -144,6 +144,38 @@
<literal>config.txt</literal> file when needed, without overwriting any
user settings.
</para>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above paragraph about non-volatile memory needs to be updated to apply only to RPi3/CM3, not RPi4 which has EEPROM. Boot device order needs to be checked on, but date/time still is not saved.

Comment on lines -326 to +358
<term>&sls; 15 SP3 Release Notes</term>
<term>&sls; 15 SP4 Release Notes</term>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be advisable to keep that in a separate commit, to facilitate your backporting to SP3 (and any SLE Micro 5.x releases based on SP3). Currently combined with addition of RPi4. Could even be done in a separate SR to not be blocked by text discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants