feat: allow media source swapping #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a parameter to `SassWorkspaceCompiler#compile` function to disable the compression of the resulting css.
Resolved #7 by adding a new toggle pane button containing an input field for changing the current media of the player. Only URNs are accepted. Other chnages: - Disabled tracking for the preview player.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Added a div container to ensure that the parent of the element passed to video.js is not the shadow root directly. This workaround resolves the issue until a permanent fix is implemented in video-js, see: videojs/video.js#8679
amtins
reviewed
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved #7 by adding a new toggle pane button containing an input field for changing the current media of the player. Only URNs are accepted.
Changes Made
SassWorkspaceCompiler#compilefunction to toggle the compression of the resulting css.Checklist