Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

950 load plugins in a separate namespace #953

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jesper-friis
Copy link
Collaborator

Description

Evaluate Python plugins in fully separate namespaces. This will hopefully get rid of the long-standing issue with possible interactions between plugins. This issue became even worse when we started to evaluate the plugins using the calling interpreter.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Sep 27, 2024 that may be closed by this pull request
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I only wish for a test. Suggestion: import pyyaml, run dlite with a plugin so that the the yaml plugin is loaded. Do something with pyyaml.

@jesper-friis
Copy link
Collaborator Author

Nice. I only wish for a test. Suggestion: import pyyaml, run dlite with a plugin so that the the yaml plugin is loaded. Do something with pyyaml.

Added test_isolated_plugins.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load plugins in a separate namespace
2 participants