New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Rect as position and size vectors #2972
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 8990773841Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I feel about this yet, just a few random comments after a first skim.
I really like this idea. Conceptually a Any ergonomic issues introduced by this refactor can be fixed by adding the right new member functions. |
046e3c7
to
a9c95ed
Compare
Note that I'm keeping separate commits for the review but I'll squash related commits once we are ready to merge. |
bc1cdf4
to
f46705c
Compare
This groups
sf::Rect
membersleft
,top
,width
,height
into two vectors:position
andsize
.This makes
sf::Rect
more aligned with all SFML API working withVector2
instead of separate values.Related: #2055, #2248