Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Type Compare on Rule Matches + Standard Account Matching Rule #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

StarleyFlynn
Copy link

Added line to compare the match result type for Contact as there may be other types (i.e. the standard rule matching on account) and that throws an error.

@meruff
Copy link
Collaborator

meruff commented Jul 11, 2018

This makes a lot of sense. @karamcintyre this is the convo we had with Jonathan via email about the entity type. @StarleyFlynn I think it may also be worth adding the same check for Lead into the matchresult block near line 356. Do you mind adding that to this pull request as well? Thanks so much for your help!!

@StarleyFlynn
Copy link
Author

@meruff @karamcintyre the additional line has been added.

@karamcintyre
Copy link
Collaborator

@StarleyFlynn We want to test this but we need some more information about your use case so we can test it properly. What was the scenario that lead to your initial errors?

@StarleyFlynn
Copy link
Author

The original use case was turning on standard duplicate matching rules for Contact, and receiving an 'audit request' when inputting a second interaction from the same contact.

@StarleyFlynn StarleyFlynn changed the title Entity Type Compare on Rule Matches Entity Type Compare on Rule Matches + Standard Account Matching Rule Oct 24, 2018
Setting DMLOptions to allowSave allows duplicate matching rules that alert rather than block to save results.  This allows the standard duplicate account rule to be bypassed within the interaction context, but still warn users that they may be creating duplicate accounts when interacting with the UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants