Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that colorSpaceGetDeviceRGB cache the color space even when active display changed #3712

Merged
merged 1 commit into from May 8, 2024

Conversation

dreampiggy
Copy link
Contributor

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

This was found during the test case testSDGraphicsImageRenderer

Draw Color ColorSpace: <CGColor 0x6000027c5620> [<CGColorSpace 0x6000027c48a0> (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 1 0 0 1 )

Test Color ColorSpace: <CGColor 0x6000027c5980> [<CGColorSpace 0x6000027c48a0> (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)] ( 0.978015 0.00459104 0.00225032 1 )

Also, fix the unit test on macOS.

@dreampiggy dreampiggy added the macOS AppKit for macOS label May 8, 2024
@dreampiggy dreampiggy changed the title Fix that colorSpaceGetDeviceRGB cache the color space even when active display changed Fix that colorSpaceGetDeviceRGB cache the color space even when active display changed May 8, 2024
@dreampiggy dreampiggy merged commit b8b147d into SDWebImage:master May 8, 2024
4 of 6 checks passed
@dreampiggy dreampiggy deleted the bugfix/unit_test_macos branch May 8, 2024 09:03
@dreampiggy dreampiggy added this to the 5.19.2 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS AppKit for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant