Introduce the hacky workaround for iOS 17 ImageIO indexed color png decode (Apple's bug) #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode bug This use the runtime detection instead of available check, more stable When we detect the ImageIO is buggy, we will change the correct alpha info with non-premultiplied
dreampiggy
force-pushed
the
bugfix/workaround_hacky_imageio_png_indexed_color
branch
from
9f88940
to
d5dccae
Compare
dreampiggy
changed the title
|
Update: From Apple's feedback, this issue seem been fixed in iOS 17.1 |
dreampiggy
added
fix
apple bug
dreampiggy
commented
Nov 15, 2023
| return SDCGImageCreateMutableCopy(image, CGImageGetBitmapInfo(image)); | ||
| } | ||
|
|
||
| static BOOL SDLoadOnePixelBitmapBuffer(CGImageRef imageRef, uint8_t *r, uint8_t *g, uint8_t *b, uint8_t *a) { |
There was a problem hiding this comment.
Is this useful for other thing ? May consider to expose to public API like +[SDImageCoderHelper CGImageGetRGBA]
This was referenced Nov 15, 2023
Closed
|
Note the PR changes is not correct and complete. Must use the code from #3637 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This use the runtime detection instead of available check, more stable
When we detect the ImageIO is buggy, we will change the correct alpha info with non-premultiplied
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This is the ultimate solution for Apple's bug #3605
Workaround steps