feat: Add ui5lint-disable directives #327
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
changed the title
flovogt
reviewed
Sep 30, 2024
| blocked: true, // IGNORE: Property "blocked" is deprecated | ||
| tap: () => console.log("Tapped") // IGNORE: Event "tap" is deprecated | ||
| }); | ||
| // ui5linter-enable |
There was a problem hiding this comment.
as far as I see, eslint does not support line comments for eslint-disable and eslint-enable. .... only block comments are supported. So I would recommend to have the same behavior for ui5linter comment rules
There was a problem hiding this comment.
You're right, nice catch. Also see the eslint implementation: https://github.com/eslint/eslint/blob/7fb0d957c102be499d5358a74928e0ea93913371/lib/linter/linter.js#L419
flovogt
reviewed
Sep 30, 2024
| "sap/ui/table/Table", "sap/ui/table/plugins/MultiSelectionPlugin", "sap/ui/core/Configuration", "sap/m/library" | ||
| ], function(Button, DateTimeInput, includes, Device, coreLib, NavigationHandler, Table, MultiSelectionPlugin, Configuration, mobileLib) { | ||
|
|
||
| // ui5linter-disable-next-line ui5-linter-no-deprecated-api |
There was a problem hiding this comment.
i am in favor of using ui5lint- instead of ui5linter-.
Why?
- shorter, less chars
- same as
ui5lintcommand - follows
eslint-comments
There was a problem hiding this comment.
Fully agree 👍 This commit was created before that discussion, I forgot to update it.
RandomByte
force-pushed
the
add-directives
branch
2 times, most recently
from
1e3a049
to
8310167
Compare
RandomByte
force-pushed
the
add-directives
branch
from
8310167
to
968c4e0
Compare
JIRA: CPOUI5FOUNDATION-911
RandomByte
force-pushed
the
add-directives
branch
from
968c4e0
to
4063044
Compare
RandomByte
force-pushed
the
add-directives
branch
from
4063044
to
04cf2de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-911