Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose with cds-plugins #555

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Compose with cds-plugins #555

wants to merge 10 commits into from

Conversation

danjoa
Copy link
Member

@danjoa danjoa commented Jul 26, 2023

No description provided.

app.serve ('/data') .from('@capire/data-viewer','app/viewer')
app.serve ('/admin-authors') .from ('@capire/fiori','app/admin-authors')
app.serve ('/admin-books') .from ('@capire/fiori','app/admin-books')
app.serve ('/browse-books') .from ('@capire/fiori','app/browse')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these apps are not loading correctly by starting cds w from compose or bookstore yet
@capire/fiori annotations for UIs are only loaded when starting with cds w fiori.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps are not loaded correctly, as they don't have an index.html file

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in ./fiori they are loaded through a fiori-apps.html
However using this (e.g. app.serve ('/fiori-apps') .from ('@capire/fiori','app/fiori-apps.html'))instead doesn't work either, because the fioriSandboxConfig.json is not found, hence it's showing a generic FLP with random apps missing the ones we would want to show.

Therefore, we need to copy the app/appconfig/fioriSandboxConfig.json to achieve a similar behavior

@DanSchlachter
Copy link

DanSchlachter commented Aug 3, 2023

do we need to copy from server.js to cds-plugin.js and vice versa to allow using the same project as composed and directly?
Are we aiming for cds w to behave similar to cds build (i.e. looking at the same files) ? Currently that's not the case

@DanSchlachter
Copy link

I think now cds w compose and cds w bookstore lead to the same result (Fiori Apps working with local launchpage, swagger UI, OData v2, same files loaded...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants