Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinook Media Store #176

Draft
wants to merge 80 commits into
base: main
Choose a base branch
from
Draft

Chinook Media Store #176

wants to merge 80 commits into from

Conversation

danjoa
Copy link
Member

@danjoa danjoa commented Nov 26, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2020

CLA assistant check
All committers have signed the CLA.

@dimaanj dimaanj force-pushed the media-store branch 6 times, most recently from 2956285 to e4fa2d3 Compare December 24, 2020 13:17
@dimaanj
Copy link

dimaanj commented Dec 24, 2020

Last corrections since the last session

  • jest timeout changed from 5000 to 10000 to support new chinook test
  • revised folder layout → putting all frontend-related things under ./app. Adjusted webpack config for that
  • renamed media-store to chinook.
  • tests → to be included in our regular tests. tests moved to /test folder
  • app/html5Deployer/resources should be cleaned up each build. It is not really webpack task to clean folder besides js build. Webpack prevents doing things outside root src. More applicable will be clean it somehow by bash/cmd automated scripts
  • added mocked secret strings to mta.yaml the same as in .env for dev

Suppose someone should do this later:

  • rename bookshop to books and fiori to bookstore. Because it leads to problems with test runner. Suppose package.json and other things should be changed at one time with renaming folders
  • exclude app/front from cds watcher. See my suggestion here

Needs update

  • add chinook to top-level ./samples.md
  • review models
  • review code
  • double-check auth.js
  • launching w/ cds watch as usual including react frontend
  • double-check corsMiddleware
  • deploy(ed) to CF

@danjoa danjoa changed the title Media store Chinook Media Store Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants