CryptoPAN #861
Open
CryptoPAN #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Feb 25, 2023
| use std::net::{Ipv4Addr, Ipv6Addr}; | ||
|
|
||
| /// The CryptoPAN anonymizer | ||
| pub struct CryptoPAn { |
There was a problem hiding this comment.
Per RFC 430 I think this should just be CryptoPan:
Suggested change
| pub struct CryptoPAn { | |
| pub struct CryptoPan { |
newpavlov
reviewed
Feb 28, 2023
There was a problem hiding this comment.
As suggested in the previous PR, I think it's worth to make CryptoPan generic over the cipher traits. The original paper (unsurprisingly) defines the algorithm in a generic fashion and even mentions AES ciphers with other key lengths. In addition to supporting other ciphers, such change would also allow to use reference to cipher (i.e. &Aes128) instead of owned instance.
I would also remove dependency on bitvec, but we can do it in a separate PR.
| readme = "README.md" | ||
|
|
||
| [dependencies] | ||
| aes="0.8.1" |
There was a problem hiding this comment.
Suggested change
| aes="0.8.1" | |
| aes = "0.8.1" |
Comment on lines
+36
to
+37
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from RustCrypto/utils 831
CryptoPAN is a prefix-preserving IP address anonymization algorithm.