x509-ocsp/remove lifetimes and implement AsExtension #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great at first glance! Can do a more in-depth review later |
baloo
reviewed
Oct 25, 2023
baloo
reviewed
Oct 25, 2023
baloo
reviewed
Oct 25, 2023
x509-ocsp/src/ext.rs
Outdated
|
|
||
| /// Trait to be implemented by extensions to allow them to be formated for x509 OCSP | ||
| /// requests/responses. | ||
| pub trait AsExtension: AssociatedOid + der::Encode { |
There was a problem hiding this comment.
Is there a reason we can't pull x509_cert::ext::AsExtension ?
Besides the const that looks very similar.
There was a problem hiding this comment.
It can be used. The extra subject/extensions arguments for judging criticality didn't seem relevant at all to OCSP though.
There was a problem hiding this comment.
Yeah, that doesn't creep in the signer itself and it stays in the builder. Not a big deal.
Up to you :)
There was a problem hiding this comment.
If we change x509_cert::ext::AsExtension to accept subject as Option<&Name>, it'd be easier. Otherwise, I think I'd have to build an empty Name just to ignore it later.
baloo
reviewed
Oct 25, 2023
baloo
approved these changes
Oct 25, 2023
baloo
reviewed
Oct 25, 2023
bhesh
deleted the
x509-ocsp/remove-lifetimes-and-implement-AsExtension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version reorganizes x509-ocsp into separate files for readability and makes use of alloc to remove lifetimes. It also implements an OCSP version of AsExtension for all possible Extensions outlined in RFC-6960 (in a similar fashion to x509-cert) to be used in a future builder. Optional rand_core feature for generating nonces.