Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment to address #1206 #1226

Merged
merged 1 commit into from
Sep 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add comment to address #1206
carl-wallace committed Sep 20, 2023
commit 5e636d538e87dc5c6da26960d548743e9c2418e6
10 changes: 10 additions & 0 deletions crmf/src/request.rs
Original file line number Diff line number Diff line change
@@ -90,6 +90,16 @@ pub struct CertRequest {
/// extensions [9] Extensions{{CertExtensions}} OPTIONAL }
/// ```
///
/// Note, the EXPLICIT tagging attribute used in the definition of the the issuer and subject fields
/// is because Name is a CHOICE and the original tag type cannot be obscured by an IMPLICIT tag.
/// See 31.2.6 in X.680:
///
/// ```text
/// All application of tags is either implicit tagging or explicit tagging. Implicit tagging
/// indicates, for those encoding rules which provide the option, that explicit identification
/// of the original tag of the "Type" in the "TaggedType" is not needed during transfer.
/// ```
///
/// [RFC 4211 Section 5]: https://www.rfc-editor.org/rfc/rfc4211#section-5
#[derive(Clone, Debug, Eq, PartialEq, Sequence)]
#[allow(missing_docs)]