ALSA: fix buffer size / period size configuration, JACK: update to 0.13.0 and fix compilation errors #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abique
force-pushed
the
fix-alsa-period-size-configuration
branch
2 times, most recently
from
2222ff1
to
d75baff
Compare
|
I can confirm that this fixes intialization of Hercules DJControl Inpulse 500 on Linux with ALSA. |
abique
changed the title
abique
force-pushed
the
fix-alsa-period-size-configuration
branch
from
89683e7
to
b996a61
Compare
abique
force-pushed
the
fix-alsa-period-size-configuration
branch
8 times, most recently
from
5a4b73f
to
9e68ef6
Compare
abique
force-pushed
the
fix-alsa-period-size-configuration
branch
6 times, most recently
from
dcf034e
to
3a5453c
Compare
abique
force-pushed
the
fix-alsa-period-size-configuration
branch
from
3a5453c
to
3ee72bb
Compare
With ALSA, the buffer size is `nperiod * period_size`. We want 2 periods. The default was far too large, 1024 samples is a much more reasonable default (still too large for real-time audio). Fixes RustAudio#913
abique
force-pushed
the
fix-alsa-period-size-configuration
branch
from
3ee72bb
to
43d1cf8
Compare
This was referenced Sep 24, 2024
|
I've split this pull request into 4 ones, for easier review and accept/reject. See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ALSA, the buffer size is
nperiod * period_size. We want 2 periods.The default was far too large, 1024 samples is a much more reasonable default (still too large for real-time audio).
Fixes #913