-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Formatting #28
base: master
Are you sure you want to change the base?
Add Formatting #28
Conversation
- Add formatting with prettier - Add prettierrc.json and ignore files - Remove Sleep package and use shell.exec('sleep x') instead - Fix config file creation if file does not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
watchdog.js
Outdated
@@ -165,75 +152,71 @@ return; | |||
var msg_text = 'KDA node sync freez detected!'; | |||
await send_telegram_msg(emoji_title,info_type,field_type,msg_text,label);*/ | |||
|
|||
sleep.sleep(3); | |||
shell.exec("sleep 3"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure If I am a big fun of this change.
I think I prefered old sleep lib, instead of calling shell to sleep :)
- Remove KDA checks and functions - Remove unused packages (axios and https) - Remove unused variables Favor sleep package instead of shell.exec
I added the sleep package back and changed all sleep commands to use it, instead of shell.exec I had also discussed with @XK4MiLX, about removing KDA checks from watchdog so those functions are now removed, along with unused packages and variables. Version is not bumped yet. |
If the kda checks works they should remain, as we still run some kda infrastructure that is used on Zelcore. |
That part of code do nathing continer name are diff and chainwebdata using separate component |
@XK4MiLX what is the state of this PR? Can the version be bumped and after merged? |
This PR add formatting standards to the project to help with maintainability, along with a few other additions.
Add formatting with prettier
Fix config file creation if file does not exist
Changed the shell.exec command to use the full path to the binary (/usr/local/bin/flux-cli) to fix issues where flux-cli is returning an error.
Remove KDA checks and unused packages