Merge pull request #269 from biostaz/gridsearch-best-params

GridSearch score sorting
RubixML · Dec 6, 2022 · 48624ad · 48624ad
2 parents 4cda6bc + c98c00b
commit 48624ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/GridSearch.php b/src/GridSearch.php
@@ -285,7 +285,7 @@ public function train(Dataset $dataset) : void
 
         $scores = $this->backend->process();
 
-        array_multisort($scores, $combinations, SORT_DESC);
+        array_multisort($scores, SORT_DESC, $combinations);
 
         $best = reset($combinations) ?: [];
 

diff --git a/tests/GridSearchTest.php b/tests/GridSearchTest.php
@@ -140,5 +140,13 @@ public function trainPredictBest() : void
         $score = $this->metric->score($predictions, $testing->labels());
 
         $this->assertGreaterThanOrEqual(self::MIN_SCORE, $score);
+
+        $expectedBest = [
+            'k' => 10,
+            'weighted' => true,
+            'kernel' => new Manhattan(),
+        ];
+
+        $this->assertEquals($expectedBest, $this->estimator->base()->params());
     }
 }