Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve respond_to handling for is_..? methods #587

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improve respond_to handling for is_..? methods #587

wants to merge 3 commits into from

Conversation

sampatbadhe
Copy link

@sampatbadhe sampatbadhe commented Dec 25, 2022 •
edited
Loading

@sampatbadhe
Copy link
Author

@EppO Could you please take a look into this PR.

@thomas-mcdonald
Copy link
Member

Is it possible to add a test case for the change covering what this fixes?

@sampatbadhe
Copy link
Author

@thomas-mcdonald I added specs and also made change to Undefine dynamic methods on removing last role, could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use of dynamic finders defines respond_to? method
2 participants
@sampatbadhe @thomas-mcdonald