Support auditing needs by switching to has_many, through
#583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from HABTM to
has_many
andhas_many through:
This will allow users to add columns like
id
andcreated_at
to the intermediate table and use paper_trail to track changes to this table, as well as gems like paranoia to soft-delete those records. All of this is super-important from a security auditing perspective.Pulled code from a PR made about 9 months ago that failed tests and was abandoned. Made further changes based on my own needs to adequately support timestamp columns, soft-delete (paranoia) and paper_trail.
I am deliberately removing the records in the join table using
destroy_all
to trigger proper eventing with timestamps and paper_trail, and then still honoring the options removal of role records no longer in use.