Support polymorphic relations by using has_many :through
#571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks again for all of your work!
Closes #570
This proposal is a minimal implementation to support polymorphic associations from multiple models that call
resourcify
, to multiple models that callrolify
.It replaces, in a rudimentary way, the
has_and_belongs_to_many
into twohas_many
relations with an explicit join table and passes the:as
option to that join table.I couldn't quite get all of the specs to run after trying for a while, but 49 of them did succeed before the rest failed on database setup. I also could not find the file or spec context for the
rolify
method, but I would love to spec this feature & help out!Database setup error log
Example polymorphic setup
Usage
Please let me know what you think and let me know if there is anything I can do to help!
Other related issues: #318, #411
Related PR: #181