Make base class generic #1937
Open
Make base class generic #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support it to be extended to override hooks like onClose, onOpen... a generic interface is needed to pass more args, what do you think?
|
@betocantu93 I am not opposed to it. If you create a file to extend this in your code base, is TS still upset if you define a new signature? |
|
Yes, it simply says that it's not a generic type |
|
@betocantu93 okay, I am fine with this. It looks like there is a lint failure. Do you mind fixing? Also, what args are you adding that you needed to extend for? Are there more we should add to the addon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support it to be extended to override hooks like onClose, onOpen... a generic interface is needed to pass more args, what do you think?