Add Ripper for nsfwalbum.com #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st one of them, more will be added before pull request is made.
|
It says the checks were not successful, this is my first pull request, can someone help me out here? From what I can gather the test failures aren't related to my contribution. |
metaprime
approved these changes
Jan 4, 2025
metaprime
pushed a commit
that referenced
this pull request
Jan 4, 2025
I've gone ahead and added a ripper for nsfwalbum.com. They host their images on many different image hosting sites so you must replace part of the image urls to get the full image instead of the thumbnails. There may be more hosts that I did not find, they can be added in later very easily.
|
I've cherry-picked the commit that resulted from merging this PR into main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
I've gone ahead and added a ripper for nsfwalbum.com.
They host their images on many different image hosting sites so you must replace part of the image urls to get the full image instead of the thumbnails.
There may be more hosts that I did not find, they can be added in later very easily.
Testing
Required verification:
mvn test(there are no new failures or errors).Optional but recommended:
NOTES:
mvn test failed, i think it may because of how my maven is setup, it doesnt reference any files of ripme in the stacktrace, i can post the error if that is helpful.
I don't have any experience on how to do unit testing, I am eager to learn if someone wants to help and give me a quick run down.