Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redgif ripper (As yet, unable to test) #1664

Closed
wants to merge 2 commits into from

Conversation

cinnamonbubblegum
Copy link

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Been unable to test due to all my proxy attempts not working. Would love if someone else could check if

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended. (Can't test due to Socks proxy isn't used (by the looks of things) #1663)
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

It'll now work for more than just this one dude
Mainly by copying existing work on gfycat, since it's practically the same.
@ghost
Copy link

ghost commented May 22, 2020

Tested

Single image works - tested with https://www.redgifs.com/watch/negligibledeficientauklet-small-tits-blonde-asian-boobs

User - https://www.redgifs.com/users/breeboo

[!] Error while ripping URL https://www.redgifs.com/users/breeboo
org.json.JSONException: JSONObject["video"] not found.
	at org.json.JSONObject.get(JSONObject.java:573)
	at org.json.JSONObject.getJSONObject(JSONObject.java:766)
	at com.rarchives.ripme.ripper.rippers.RedGIFSRipper.getURLsFromPage(RedGIFSRipper.java:129)
	at com.rarchives.ripme.ripper.AbstractHTMLRipper.rip(AbstractHTMLRipper.java:112)
	at com.rarchives.ripme.App.rip(App.java:103)
	at com.rarchives.ripme.App.ripURL(App.java:296)
	at com.rarchives.ripme.App.handleArguments(App.java:279)
	at com.rarchives.ripme.App.main(App.java:78)

Browsing tag https://www.redgifs.com/gifs/browse/mollyredwolf

[!] Error while ripping URL https://www.redgifs.com/gifs/browse/mollyredwolf
org.json.JSONException: JSONObject["video"] not found.
	at org.json.JSONObject.get(JSONObject.java:573)
	at org.json.JSONObject.getJSONObject(JSONObject.java:766)
	at com.rarchives.ripme.ripper.rippers.RedGIFSRipper.getURLsFromPage(RedGIFSRipper.java:129)
	at com.rarchives.ripme.ripper.AbstractHTMLRipper.rip(AbstractHTMLRipper.java:112)
	at com.rarchives.ripme.App.rip(App.java:103)
	at com.rarchives.ripme.App.ripURL(App.java:296)
	at com.rarchives.ripme.App.handleArguments(App.java:279)
	at com.rarchives.ripme.App.main(App.java:78)

Tested via ripping a subreddit, seems the url follows a different structure when shared to Reddit

[!] Unable to rip URL: https://redgifs.com/watch/yellowlegitimatedragonfly

@CaptRussia
Copy link

I just built and tested the master branch and have similar results as @Pocochub .

Ripping is successful on individual redgif links, however, when parsing a subreddit or user it simply ignores the links. 🤔

@metaprime
Copy link
Contributor

We currently have a working RedgifsRipper in main

@metaprime metaprime closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants