Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote ClipboardUtils regex #1361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyian-1756
Copy link
Collaborator

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Can now rip links including @ from the clipboard

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@Klutronic
Copy link

Klutronic commented Jul 20, 2020

This does not fix the drop of leading or trailing "_" (underscores) in Reddit usernames when the user folder is written to disk.

@soloturn
Copy link
Collaborator

soloturn commented Nov 21, 2020

This does not fix the drop of leading or trailing "_" (underscores) in Reddit usernames when the user folder is written to disk.

why this is important @Klutronic, at this place in the code? how do you notice it?

@Klutronic
Copy link

Hi @soloturn. I believe @cyian-1756 mentioned that the regex at this point was causing the issue. I recompiled with the updated regex and RipMe still omitted the leading and/or trailing underscores from the reddit user folder when it was written.

@soloturn soloturn changed the base branch from master to main January 2, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic copy breaks Flickr links
3 participants