Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag comparisons #3909

Merged
merged 3 commits into from
May 22, 2024
Merged

Flag comparisons #3909

merged 3 commits into from
May 22, 2024

Commits on May 21, 2024

  1. packages - allow enabling/disabling a module with comparison flags 

    rp_module_flags can now contain a variable comparison to enable or disable a scriptmodule.
The comparison should be in the format :\$var:cmp:val or !:\$var:cmp:val

eg. :\$__gcc_version:-lt:7 would be evaluated as [[ $__gcc_version -lt 7 ]]

This would enable a module if the comparison was true or disable if !:\$__gcc_version:-lt:7 was used.
Only global variables set before modules are loaded (eg via system.sh) are supported.

$ is escaped so variables are not evaluated when the module is sourced.
It works without, but provides less useful information in the setup menus as the variable name will not be visible.
    @joolswills
    joolswills committed May 21, 2024
    Configuration menu
    Copy the full SHA
    781618e View commit details
    Browse the repository at this point in the history

  2. Convert modules to using variable comparisons in flags 

    Replace GCC version checks in depends_* functions with variable comparisons in flags.
    @joolswills
    joolswills committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9e8362a View commit details
    Browse the repository at this point in the history

  3. mysticmine - Disable on Debian versions newer than 10 (buster) 

    The scriptmodule requires Python2 and python modules that are no longer packaged.
    @joolswills
    joolswills committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f508c6f View commit details
    Browse the repository at this point in the history