feat: add enablePatterns config option #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
approved these changes
May 2, 2024
|
cc @llllvvuu we had to disable this by default as it's causing problems for our users. |
|
Fair enough. The original implementation (vendored randexp.js) was a lot more comprehensive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
feat: add enablePatterns config option
Recently, we have added pattern generation for string values but it does not cover all regex causes. So we decided to add a new config option in order to handle it properly. By default, pattern generation is disabled.
closes: https://github.com/Redocly/redocly/issues/8271
Reference
#153
Testing
Screenshots (optional)
Check yourself
Security