Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Added KYC purpose #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added KYC purpose #576

wants to merge 1 commit into from

Conversation

adamaltman
Copy link
Member

No description provided.

@slavcodev slavcodev requested review from viceromag and removed request for viceromag January 13, 2019 00:04
@destebang
Copy link

This has been almost a year in PR, @adamaltman does this PR still apply?

@adamaltman
Copy link
Member Author

Yes, it does. Hard to get a review around here. ;-)

@@ -23,6 +23,11 @@ properties:
enum:
- identity-proof
- address-proof
purpose:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to restrict this field to a nullable enum ?

I can not imagine too many reasons to request a KYC check (basically it can serve the purpose of accepting a customer or to send money to someone). Having an enum would also allow us to get an understanding of what is the most common use of this tool.

Also, we always can evolve from an enum to a string while the opposite would be more difficult.
I am not sure enough about all the possible values the enum could accept, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make sense. Maybe these:

- acceptance
- remittance
- investor
- other

What do you think of those possible values?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those values seem ok to me as a starting point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamaltman Those possibilities seem okay for now. We can always add to or change the enum if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants