reworked startup, changed order of checks. Updated isStartup function…

[cloud9team]

Changed isStartup in misc.swift. The caution prompts are needed to complete startup in part8main, isStartup will return true, but not click caution until part8. Moved rw detection above closeNews (closeNews was actually clearing rw before rw check, why it never worked). Removed the check for account manager in part1setup so the failed login and tos checks can run there and not create 42 checks in logs.

Description

changes made to misc.swift. added a variable with default value of 0. only clicks warning sign when value is 1.
Realdevicemap_uicontroltests.swift - removed check for account manager in part1setup.
Moved screen check for age verification and login to first 2 checks. Next check is failed login. then tos check. Added a delay between these checks so they do not run more than necessary.
Moved closeNews to click after check for rw, closeNews has been blindly closing rw and thats why rw detection has never worked.
isStartup will not close the caution prompt until part8main. It is the only thing that sets isStarted to true in the entire program (part8main). Removed all tos checks from inside part8main because those checks will never exist there (tos comes before caution, can't get to caution without clearing tos, can't get inside code block where tos checks were without clearing caution sign)

Motivation and Context

see above

How Has This Been Tested?

with devices

a dark cold room with dim lights and glowing eyes. Mac OS, iPhone se.

Screenshots (if appropriate):

Types of changes

• [ x] Bug fix (non-breaking change which fixes an issue)
• [ x] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ x] My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[cloud9team]

All changes made and pr passes all checks, been running 6 hours now, devices have not had to rebuild since starting manager. Sample logs of startup with this pr >>

[2020-03-09 13:59:00 GMT-04:00] [STATUS] Startup
[2020-03-09 13:59:00 GMT-04:00] [DEBUG] Checking for the failed to login pop-up
[2020-03-09 13:59:00 GMT-04:00] [DEBUG] App still in Startup
[2020-03-09 13:59:01 GMT-04:00] [DEBUG] Checking for the failed to login pop-up
[2020-03-09 13:59:02 GMT-04:00] [DEBUG] App still in Startup
[2020-03-09 13:59:03 GMT-04:00] [DEBUG] Checking for the failed to login pop-up
[2020-03-09 13:59:03 GMT-04:00] [DEBUG] App still in Startup
[2020-03-09 13:59:04 GMT-04:00] [DEBUG] Checking for the failed to login pop-up
[2020-03-09 13:59:05 GMT-04:00] [DEBUG] App still in Startup
[2020-03-09 13:59:05 GMT-04:00] [DEBUG] Got Data without GMO
[2020-03-09 13:59:09 GMT-04:00] [DEBUG] Checking for the failed to login pop-up
[2020-03-09 13:59:09 GMT-04:00] [DEBUG] App still in Startup
[2020-03-09 13:59:10 GMT-04:00] [DEBUG] Got Empty Data
[2020-03-09 13:59:10 GMT-04:00] [DEBUG] Got Empty Data
[2020-03-09 13:59:11 GMT-04:00] [DEBUG] Checking for the failed to login pop-up
[2020-03-09 13:59:11 GMT-04:00] [Startup] Clearing Caution Sign prompt
[2020-03-09 13:59:11 GMT-04:00] [INFO] App Started
[2020-03-09 13:59:12 GMT-04:00] [DEBUG] Performing Startup sequence
[2020-03-09 13:59:13 GMT-04:00] [DEBUG] Checking for the red warning
[2020-03-09 13:59:21 GMT-04:00] [STATUS] Pokemon
[2020-03-09 13:59:21 GMT-04:00] [DEBUG] Scanning for Pokemon at..

[123FLO321]

Code looks good now.
However haven't tested the changes yet.