Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: streamline CI workflow #7453

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 3 additions & 14 deletions .github/workflows/ci_main.yml
Expand Up @@ -25,21 +25,10 @@ jobs:
node-version: ${{ matrix.node }}

- name: Build, test and lint all projects (except website)
run: yarn nx run-many -t build lint test --exclude=rxjs.dev

- name: rxjs lint
run: yarn workspace rxjs lint
- name: rxjs build
run: yarn workspace rxjs build
- name: rxjs test
run: yarn workspace rxjs test
- name: rxjs dtslint
run: yarn workspace rxjs dtslint
- name: rxjs test:import
run: yarn workspace rxjs test:import
- name: rxjs test:esm
run: yarn workspace rxjs test:esm
run: yarn nx run-many -t build lint test dtslint test:import test:esm --exclude=rxjs.dev

- name: rxjs.dev build
run: yarn workspace rxjs.dev build --prod

- name: rxjs.dev test
run: yarn workspace rxjs.dev test --watch=false --browsers=ChromeHeadless
3 changes: 0 additions & 3 deletions nx.json
Expand Up @@ -9,9 +9,6 @@
"inputs": ["production", "^production"],
"cache": true
},
"test:circular": {
"dependsOn": ["build"]
},
"test": {
"cache": true
},
Expand Down
1 change: 0 additions & 1 deletion package.json
Expand Up @@ -57,4 +57,3 @@
"*.{js,css,md}": "prettier --write"
}
}

25 changes: 24 additions & 1 deletion packages/rxjs/package.json
Expand Up @@ -60,7 +60,7 @@
},
"scripts": {
"lint": "eslint --ext=ts,js src spec spec-dtslint",
"dtslint": "npm run lint && tsc -b ./src/tsconfig.types.json",
"dtslint": "tsc -b ./src/tsconfig.types.json",
"test": "cross-env TS_NODE_PROJECT=tsconfig.mocha.json mocha --config spec/support/.mocharc.js \"spec/**/*-spec.ts\"",
"test:esm": "node spec/module-test-spec.mjs",
"test:circular": "dependency-cruiser --validate .dependency-cruiser.json -x \"^node_modules\" dist/esm",
Expand Down Expand Up @@ -180,6 +180,29 @@
"dependsOn": [
"^build"
]
},
"test:esm": {
"dependsOn": [
"build"
],
"cache": true
},
"test:circular": {
"dependsOn": [
"build"
]
},
"test:import": {
"dependsOn": [
"build"
],
"cache": true
},
"dtslint": {
"dependsOn": [
"^build"
],
"cache": true
}
}
}
Expand Down