Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 0.50.1 #76

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Cherry pick 0.50.1 #76

wants to merge 8 commits into from

Conversation

p4checo
Copy link
Collaborator

@p4checo p4checo commented Jan 31, 2023

Changes

  • Cherry-pick upstream changes up to 0.50.1 🏷️

stephencelis and others added 7 commits January 31, 2023 20:00
(cherry picked from commit 7cb8776deef91115a2d4a262ea2f5205981276c4)
(cherry picked from commit 71bab05171f157f065a3609bb6824ec0bac3db27)
* Add note to reducer protocol dependency section

The discussion #1870 noted that our migration guide could include more
of a breadcrumb that migrating to the Dependencies library isn't a
simple matter of changing every environment property to a `@Dependency`
property.

* wip

Co-authored-by: Brandon Williams <[email protected]>
(cherry picked from commit 1a168e2397981bd54e4c746ba50b92b7b92dfa07)
* `IfLetStore`: ignore view store binding writes to `nil` state

* swift-format

* wip

* add test for filter

---------

Co-authored-by: Brandon Williams <[email protected]>
(cherry picked from commit 98af2adcb5a6186168a60dd1db834e39a34aa4e1)

# Conflicts:
#	Sources/ComposableArchitecture/Store.swift
#	Sources/ComposableArchitecture/SwiftUI/IfLetStore.swift
#	Sources/ComposableArchitecture/ViewStore.swift
#	Tests/ComposableArchitectureTests/StoreTests.swift
* Add test case for binding action crash

* Workaround layout issue

* flakey test

* wip

(cherry picked from commit c3304961646bd6b6fd71e311d48950b1d63bd930)

# Conflicts:
#	Tests/ComposableArchitectureTests/BindingTests.swift
(cherry picked from commit 00738db7b9176588dff08e78de6daa18f7cb3728)
* Make Store.filter internal

We're seeing that `@_spi` can still come up in autocomplete. Now Xcode
surfaces internal stuff too occasionally, but maybe this will suppress
it a bit.

* wip

* fix

(cherry picked from commit b690a617d1366bd36f047e5da5d3185f20daac71)
@p4checo p4checo requested a review from mluisbrown January 31, 2023 23:39
@p4checo p4checo force-pushed the cherry-pick-0.50.1 branch from 0d6f470 to 396ae72 Compare January 31, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants