Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with badges and package manager info. #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README with badges and package manager info. #96

wants to merge 1 commit into from

Conversation

andersio
Copy link
Member

Is this enough though?

erichoracek
erichoracek approved these changes Apr 29, 2017
View reviewed changes
README.md
@@ -513,6 +515,26 @@ To add RAC to your application:
To see a project already set up with RAC, check out [C-41][] or [GroceryList][],
which are real iOS apps written using ReactiveObjC.

#### Carthage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go above the submodule section (the same way it is in ReactiveCocoa)? It seems like Carthage or CocoaPods would be the most common installation routes over submodules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have a #### Git Submodules header too, I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the section need to be updated though? It seems too complicated if linking the library is enough (in regard to Carthage and Pods).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving it to the bottom of the list and adding a header is sufficient.

mdiep
mdiep approved these changes Apr 29, 2017
View reviewed changes
Copy link
Contributor

@mdiep mdiep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 when the note above is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdiep mdiep mdiep approved these changes

@erichoracek erichoracek erichoracek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersio @mdiep @erichoracek