First pass at supporting user apps #9760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of previous work by Red in #9406 and their subsequent branch. I've merely adapted and fixed some of it.
There are a few things I'm mostly nebulous about that I need to mull over some more:
authorized_integration_owner
type is pretty useless, I can't imagine a use case for it nor a good way to expose it since its information is duplicated elsewhere in the schema.AppIntegrationType
as a type feels wrong. It should probably be an enum or renamed toAppInstallationType
since that's.. what it is. The original naming feels like a misstep on Discord's side.AppContextType
is anArrayFlags
currently but due to a losing battle discussing this with them I think this might be better off as anEnum
instead.install_types
/user_install
/guild_install
but the inner types and properties are calledintegration_types
. Again, this feels like a misstep on Discord's side.channel.permissions_for
code that people have littered around.interaction_metadata
type needs to be added toMessage
AppInfo
need to be added as well.