Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: we now call PlayerManager.tickAll() directly. #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markscho
Copy link

@markscho markscho commented Feb 5, 2019

Currently, it is doing a PlayerManager.emit('updateTick') when it could be doing PlayerManager.tickAll(). That's because the updateTick event ONLY is doing a .tickAll().
This seems unnecessary and makes it more consistent with how we're calling AreaManager.tickAll() and ItemManager.tickAll() at set intervals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants