e2e: describes configs used in config.yaml.sample #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added comments for different options except for pvc properties(self explaining) * Shows sample clusters, can be uncommented out to make it easy to configure kubeconfig paths. Signed-off-by: Parikshith <[email protected]>
nirs
reviewed
Jan 26, 2025
| @@ -1,11 +1,35 @@ | |||
| --- | |||
| # Configuration file for RamenDR E2E testing on Regional DR. | |||
|
|
|||
| # Name of the channel used for the Channel CR (utilized by Subscription CRs). | |||
There was a problem hiding this comment.
Also by ApplicationSet, so we can just mention that OCM is using this to pull the application from git.
|
|
||
| # Sample cluster configurations (commented out by default): | ||
| # Uncomment and edit the following lines to provide the kubeconfig paths | ||
| # for your test clusters. |
There was a problem hiding this comment.
We can remove "(commented by default)".
| # Sample cluster configurations (commented out by default): | ||
| # Uncomment and edit the following lines to provide the kubeconfig paths | ||
| # for your test clusters. | ||
|
|
There was a problem hiding this comment.
Lets remove the blank line - the all the other comments are right above the yaml item, so this should be right above the "clusters:".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1765