vrg: cleanup rd when vrg is secondary

[raghavendra-talur]

In processForDeletion, we cleanup the resources that are related to volsync. It relies on v.volSyncPVCs but the list is empty when the vrg is secondary because it is populated by looking at the vrg.status.ProtectedPVCs.

For managed applications, the RD,RS and Snapshots were being as a consequence of the deletion of VRG as the VRG is the owner for them.

In the case of discovered apps, the vrg is not the owner and therefore the RD was being left behind.

[BenamarMk]

I have a few small comments on this change:

1. The RD and RS terms in the function comment are misspelled, so this is a good opportunity to correct them.
2. The object retrieved from volSyncPVCs is an actual PVC, while the one from ProtectedPVC is not. This makes the variable name pvc in the second loop misleading. Ideally, we should have named ProtectedPVC as ProtectedPVCInfo, but it is what it is.
3. I would modify the function to look like the following, as we want to use the same function calls to delete the three resources in both cases:

func (v *VRGInstance) cleanupResources() error {
	for idx := range v.volSyncPVCs {
		pvc := &v.volSyncPVCs[idx]

		if err := v.doCleanupResources(pvc.Name, pvc.Namespace); err != nil {
			return err
		}
	}

	for idx := range v.instance.Spec.VolSync.RDSpec {
		protectedPVC := v.instance.Spec.VolSync.RDSpec[idx].ProtectedPVC

		if err := v.doCleanupResources(protectedPVC.Name, protectedPVC.Namespace); err != nil {
			return err
		}
	}

	return nil
}

func (v *VRGInstance) doCleanupResources(name, namespace string) error {
	if err := v.volSyncHandler.DeleteRS(name, namespace); err != nil {
		return err
	}

	if err := v.volSyncHandler.DeleteRD(name, namespace); err != nil {
		return err
	}

	if err := v.volSyncHandler.DeleteSnapshots(namespace); err != nil {
		return err
	}

	return nil
}

[raghavendra-talur]

Thank you. Updated as suggested!