e2e: Build and run e2e executable #1723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
commented
Dec 12, 2024
nirs
commented
Dec 12, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Change the run.sh script to build the e2e executable and run the tests using the executable. This has several advantages: - Document how the build an executable - Test the built executable for every test run - When running the executable the default -test.timeout is disable, so we don't need to specify it. This makes running the tests directly easier. Signed-off-by: Nir Soffer <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
To make it easier to inspect the log after failures. This is a quick hack until we create the log properly (RamenDR#1722). Signed-off-by: Nir Soffer <[email protected]>
Previously we uploaded only the gathered environment, but we really want
all data from the test when we try to debug a failure. Add the
e2e/ramen-e2e.log to the archive, and rename the archive to reflect the
new content.
Example content of the archive:
% tree e2e.12932857944-1 -L3
e2e.12932857944-1
├── e2e
│ └── ramen-e2e.log
└── test
└── gather.rdr
├── dr1
├── dr2
├── gather.log
└── hub
Signed-off-by: Nir Soffer <[email protected]>
Mainly for testing the previous changes, but this may be useful to keep so we can debug "successful" build, or compare successful build with failed build. Gathering data is quick (~10 seconds), and the compressed tarball is relatively small (7 MiB) and is automatically deleted after 15 days, so always collecting data does not cost a lot. Signed-off-by: Nir Soffer <[email protected]>
rakeshgm
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the run.sh script to build the e2e executable and run the tests
using the executable.
This has several advantages:
we don't need to specify it. This makes running the tests directly
easier.
The new ramen-e2e.log is also collected in the build archive.
Example content of the build archive:
Finally we gather data and upload the archive for all builds, not only for failures.
New artifacts:
Fixes #1743