Review and Update

[apoorvachikara]

gold-tub-6222:

Backend:

• NA

Frontend:

• No go back to Home Page from the contact Page and Login page
• There is no signup page on the website and unable to login to the web page
• Toaster position can be on the right-hand side
• How to create a project structure? check this: https://profy.dev/article/react-folder-structure
• Function and constants name should be descriptive, check this: https://www.syncfusion.com/blogs/post/10-javascript-naming-conventions-every-developer-should-know.aspx
• CSS modules are not created to include CSS, most of the styles are given with in-line CSS or through component style object
• The website is not responsive (you have used static styles that are passed to the UI chakra components)

GitHub:

• No description in the commit message, it should include what you have added in that commit
• There are no branches only one branch - we should do branches for every feature
• There are no PRs, you should follow this practice when in a team to review before merging in the main branch
• There is a lot of repetitive code and/or components, check this: https://reactjs.org/docs/thinking-in-react.html
• How to create a project structure? check this: https://profy.dev/article/react-folder-structure

Raj Mandloi - fw18_0133 - Intro

• Use loops instead of static lists
• You can structure the pages more clearly just an ex:
  • Home
    • main.jsx
    • body.jsx
    • home.css
• You should never give any username and password in the client code
• Login functionality is not only validating the user cred but also keeps the token for future validation(login was not working)
• Create a util function or shared module that includes the code being used at multiple places in the project
• Remove unused objects
• do follow a consistent style of coding
• Divide big components into smaller
• Remove commented code if not needed
• FreeTools.jsx - follows at least some of the standard coding practices and you should follow some good practices from it to other components too

Karan Joshi - fw18_0474 - Login Page & Contact Sales

• Login functionality is not only validating the user cred but also keeps the token for future validation(login was not working)
• You should never give any username and password in the client code
• Use loops when we need to list the same component, any lists
• Create a Constant folder where you can put different constants ex:
  • Constants
    • URL.constant.js
• Divide components into smaller components

Ranajit Das - fw18_0550 - Software Navigation Bar & Free Hubspot CRM

• Use loops instead of static lists
• Keep long static content in one place, it keeps the component clean
• divide big components into smaller ones, they will help you in the longer term to keep debugging simple and re-use the code when needed
• You can use only one component for Tabbar and reuse the same component by passing dynamic configurations to it
• Create a Constant folder where you can put different constants ex:
  • Constants
    • URL.constant.js
• Sales component is very very large, you need to keep the components lightweight. Before writing the code think about how you can design this feature with minimum code and time
• There is a lot of redundant code in the Sales component and if you structure it well same text and components can be reused.


Sanjaykumar Verma - fp03_303 - Home Page

• Put styles in different JSON files or JS files
• keep component light
• divide big components into smaller ones, they will help you in the longer term to keep debugging simple and re-use the code when needed
• URLs from constant files
• Use loops when rendering the same component, but with different config or options

Sayan Mukherjee - fw18_1070 - Pricing

• Use loops instead of static lists
• Keep long static content in one place, it keeps the component clean
• function name should be descriptive, check this: https://www.syncfusion.com/blogs/post/10-javascript-naming-conventions-every-developer-should-know.aspx
• use options or a single object to pass large de-structure lists
• divide big components into smaller ones, they will help you in the longer term to keep debugging simple and re-use the code when needed
• do follow a consistent style of coding