runsikulix.cmd should return a valid return code

[wolfc01]

This change has been made for properly passing the result of the test to a calling script.

[wolfc01]

Hello RaiMan,

please check if this pull request is OK. We use sikuli by calling runsikulix.cmd from a python test framework. Then it is essential that returncode is passed to the calling process.

Best regards
Carl.

[owillebo]

See https://en.wikipedia.org/wiki/Exit_status

Processes should exit with a non-zero value upon failure and zero upon success.

For Sikuli it is very important to adhere to this standard because (automatic) testing systems rely on it.

For instance Continuous Integration platforms like Jenkins consider jobs failed if job sub processes exit with a non-zero value.

It is essential that Sikuli can be integrated in automatic testing systems.

[RaiMan]

I principally agree, but I do not think, that runsikulix.cmd is the right way, to integrate running of scripts into whatever platforms.

runsikulix.cmd is only some easy to use command file for non-professionals.

Integration should be done using the respective java command, which gives you full control over the use of the sikulix.jar to run your scripts.

Nevertheless I will check your suggestion, especially about your deletion of the local aspect and the effect of the exit command.